D12745: Unify API for file descriptor sharing

ossi added a comment. \o/ ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a3328eaa5197: Unify API for file descriptor sharing (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12745?vs=35325=35326 REVISION DETAIL

D12745: Unify API for file descriptor sharing

chinmoyr updated this revision to Diff 35325. chinmoyr added a comment. Rebased on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12745?vs=34965=35325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745 AFFECTED FILES

D12745: Unify API for file descriptor sharing

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

chinmoyr added a comment. @dfaure can you have a look at this? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

ossi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

chinmoyr updated this revision to Diff 34965. chinmoyr edited the summary of this revision. chinmoyr added a comment. Used std::string REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12745?vs=33821=34965 BRANCH master REVISION DETAIL

D12745: Unify API for file descriptor sharing

ossi added a comment. but so does using raw pointers. as the stl is available here anyway, it seems like the preferable abstraction layer. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham,

D12745: Unify API for file descriptor sharing

chinmoyr added a comment. In D12745#268946 , @ossi wrote: > why aren't you standardizing on std::string? that's cleaner than raw char pointers. > i know we discussed this before to some degree, but i don't remember the particulars.

D12745: Unify API for file descriptor sharing

ossi added a comment. why aren't you standardizing on std::string? that's cleaner than raw char pointers. i know we discussed this before to some degree, but i don't remember the particulars. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr,

D12745: Unify API for file descriptor sharing

chinmoyr added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

D12745: Unify API for file descriptor sharing

chinmoyr updated this revision to Diff 33821. chinmoyr added a comment. Rebased on updated D12744 . REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12745?vs=33819=33821 BRANCH master REVISION DETAIL

D12745: Unify API for file descriptor sharing

chinmoyr updated this revision to Diff 33819. chinmoyr added a comment. Print the invalid socket path in case of error. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12745?vs=33775=33819 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745

D12745: Unify API for file descriptor sharing

chinmoyr created this revision. chinmoyr added reviewers: dfaure, ossi. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Pass socket path as const char* to SocketAddress,