D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

cfeck added a reviewer: VDG. cfeck added a comment. I love how phabricator thinks I wanted to remove anyone. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, #vdg Cc: alex-l, rkflx, cfeck, kde-frameworks-devel, mwolff, apol,

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

cfeck removed a reviewer: VDG. cfeck added a comment. QColor c; c = QColor(Qt::gray); qDebug() << c.lightnessF(); c = QColor(Qt::darkGray); qDebug() << c.lightnessF(); I get: 0.635294 0.501961 Both colors are very similar and neither has enough contrast for

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

alex-l added a comment. Gray seems OK to me. And I confirm the bug with Saturday column. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, #vdg Cc: alex-l, rkflx, cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham,

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

ngraham added a comment. I don't know. Perhaps it's time to involve more VDG people. #VDG , how should we style weekend days and day names? Currently we draw them in dark red, which is problematic for a few reasons: F5869969:

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

rkflx added a comment. In D12756#268345 , @ngraham wrote: > Use conditional grays instead of reds (red was never an appropriate color anyway) Hm, now Sundays look like they belong to the previous/next month. (Do we even need to change

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

ngraham edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, #vdg Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

ngraham added a reviewer: VDG. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, #vdg Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

ngraham retitled this revision from "[KDateTable] Use a more visible red color" to "[KDateTable] Use more appropriate and readable text colors for weekends and holidays". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R236