D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

2018-06-10 Thread Roman Gilg
romangg abandoned this revision. romangg added a comment. Abandoned in favor of D13084 . REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13037 To: romangg, #plasma Cc: graesslin, davidedmundson,

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

2018-05-22 Thread Martin Flöser
graesslin added a comment. I wouldn't change plasmaquick based on KWin's behavior. KWin is weird after all. We should rather work around inside KWin. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13037 To: romangg, #plasma Cc: graesslin,

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

2018-05-22 Thread Roman Gilg
romangg added a comment. In D13037#266379 , @davidedmundson wrote: > should mean the server will announce all the interfaces and we block all execution until we've processed it all. DialogShadows is created as Q_GLOBAL_STATIC. Maybe

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

2018-05-22 Thread David Edmundson
davidedmundson added a comment. This doesn't make sense (assuming everything else works correctly, which clearly isn't the case) registry->setup(); connection->roundtrip(); should mean the server will announce all the interfaces and we block all execution until we've

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

2018-05-22 Thread Roman Gilg
romangg added a task: T8771: PlasmaQuick::Dialog and/or KWin (internal window) problems. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13037 To: romangg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

2018-05-22 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Dialog might try to set PlasmaShellSurface before