D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham added a comment. The original version handled that, but I got complaints. :) will investigate and fix in a few hours. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel,

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

dfaure added a comment. This test breaks KFileItemTest: https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/136/testReport/junit/projectroot/autotests/kiocore_kfileitemtest/ QDEBUG : KFileItemTest::testIconNameForUrl(root) QUrl("file:///")

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham added a comment. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

meven added a comment. Nice work ! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:074c91a58318: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName() (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D13048 REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh,

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham updated this revision to Diff 60801. ngraham added a comment. Simplify logic to address review comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13048?vs=60649=60801 BRANCH arcpatch-D13048 REVISION DETAIL https://phabricator.kde.org/D13048

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > global.cpp:251 > +KIO::UDSEntry entry = job->statResult(); > +const KFileItem item = KFileItem(entry, url); > +i =

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. ngraham added reviewers: meven, apol, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol,

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham updated this revision to Diff 60649. ngraham added a comment. - Don't stat non-local files - Reduce the size of the change - Still works REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13048?vs=34715=60649 REVISION DETAIL

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham reclaimed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham abandoned this revision. ngraham added a comment. Let's do this in a more sensible and better-performing way with D13082 and D13083 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham updated this revision to Diff 34715. ngraham added a comment. Merge master to get those nice test fixes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13048?vs=34675=34715 BRANCH iconNameForUrl (branched from master) REVISION DETAIL

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham planned changes to this revision. ngraham added a comment. Hmm, that makes sense. OK, I'll re-work this. The problem here is that if we want to fix 356045, there's no getting around reading a `.directory` file as part of this process, but maybe I can narrowly conditionalize it

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

apol added inline comments. INLINE COMMENTS > global.cpp:332 > +KIO::StatJob *job = KIO::stat(url); > +job->exec(); > +KIO::UDSEntry entry = job->statResult(); having a blocking stat isn't good. stat will take a while on some protocols and it's not even all that quick on local file

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham created this revision. ngraham added reviewers: Frameworks, broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY `KIO::iconNameForUrl()` was doing a lot