D13535: Do not cancel old clipboard selection if it is same as the new one.

This revision was automatically updated to reflect the committed changes. Closed by commit R127:0e580ae9bdc5: Do not cancel old clipboard selection if it is same as the new one. (authored by michalsrb, committed by fvogt). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricato

D13535: Do not cancel old clipboard selection if it is same as the new one.

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13535 To: fvogt, #plasma, #frameworks, romangg Cc: michalsrb, romangg, graesslin, kde-frameworks-devel, michaelh, ngraham,

D13535: Do not cancel old clipboard selection if it is same as the new one.

fvogt updated this revision to Diff 36286. fvogt added a comment. - Add unittest. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13535?vs=36154&id=36286 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13535 AFFECTED FILES autotests/clie

D13535: Do not cancel old clipboard selection if it is same as the new one.

romangg added a comment. In D13535#278441 , @fvogt wrote: > in TestDataDevice::testReplaceSource() and it fails without this patch. > With this patch however, the selection isn't offered (is that correct behaviour?) so the wait() times out.

D13535: Do not cancel old clipboard selection if it is same as the new one.

fvogt added a comment. Yes, a unit test makes sense. I tried to add // replace the data source with itself, ensure that it did not get cancelled // replace the data source with itself, ensure that it did not get cancelled selectionOfferedSpy.clear(); dataSource2->offer(QStrin

D13535: Do not cancel old clipboard selection if it is same as the new one.

graesslin added a comment. I would appreciate a unit test for the issue. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13535 To: fvogt, #plasma, #frameworks Cc: graesslin, kde-frameworks-devel, michaelh, ngraham, bruns

D13535: Do not cancel old clipboard selection if it is same as the new one.

fvogt created this revision. fvogt added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY GTK applications seem to call wl_data_device::set