anthonyfieroni abandoned this revision.
anthonyfieroni added a comment.
Kernel regression for sure.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D13627
To: anthonyfieroni, davidedmundson, dfaure, #frameworks, hein, mpyne
Cc: mpyne, hein, kde-frameworks-devel, m
anthonyfieroni added a comment.
It looks can happen
https://www.reddit.com/r/kde/comments/9hovrv/ive_been_having_this_randomly_icons_appears_to_be/
But i'm not sure that patch can handle it.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D13627
To: anthonyfier
mpyne added a comment.
I'd say to leave the code alone if this the change isn't needed to fix a bug.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D13627
To: anthonyfieroni, davidedmundson, dfaure, #frameworks, hein, mpyne
Cc: mpyne, hein, kde-frameworks-devel,
anthonyfieroni added a comment.
I've test it too, but after kernel upgrade i don't notice it anymore, it can
be a kernel regression, it still looks valuable to you, @mpyne ?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D13627
To: anthonyfieroni, davidedmundson
mpyne accepted this revision.
mpyne added a comment.
This change has worked fine for me in my testing (including KDE games and
Plasma themes) so I think it's fine to commit.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D13627
To: anthonyfieroni, davidedmundson
mpyne added a comment.
The patch looks OK but I'm a bit worried about trying to lock the cache at
the same time we're potentially trying to delete a KSharedDataCache so I'm
going to recompile and do some stress and sanity tests first.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://
anthonyfieroni added a comment.
@mpyne , i'm unsure about file deletion and sync other than that it looks
correct. Finding best lock algorithm can be *potential* problem, but surely
it's not my best.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D13627
To: ant
anthonyfieroni updated this revision to Diff 37343.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13627?vs=36742&id=37343
REVISION DETAIL
https://phabricator.kde.org/D13627
AFFECTED FILES
src/lib/caching/kshareddatacache.cpp
To: anthonyfieroni, davi
anthonyfieroni retitled this revision from "[KIconThemes] Isolate private data
from race conditions" to "[KSharedDataCache] Assume lock before flush changes".
anthonyfieroni edited the summary of this revision.
anthonyfieroni added a reviewer: mpyne.
anthonyfieroni changed the repository for this
