This revision was automatically updated to reflect the committed changes.
Closed by commit R286:fd3319a6803b: OdfExtractor: deal with non-common prefix
names (authored by kossebau).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13719?vs=36647&id=36751
kossebau updated this revision to Diff 36647.
kossebau added a comment.
Update to Jos' feedback (thanks for that)
Using "firstChildElementNS" as name for the method, so it's closer to
QDomNode API and more telling what it does
If no-one has further comments, would commit on Wednesda
vandenoever accepted this revision.
vandenoever added a comment.
This revision is now accepted and ready to land.
Good fixes. Just some small naming suggestions.
INLINE COMMENTS
> odfextractor.cpp:37
> +
> +QDomElement namedItemNS(const QDomNode &node, const QString &nsURI, const
> QString &
kossebau created this revision.
kossebau added a reviewer: vandenoever.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
kossebau requested review of this revision.
TEST PLAN
Autotest odfextractortest still works.
R
