D13747: Fuzzy filename search for Baloo

bruns added a comment. I think this design has several problems: 1. adding or renaming documents becomes very write heavy - consider adding e.g. foobar.png - this will add 7 bigrams. Each bigram has an associated list of matching documents. The document list is sorted. This means we

D13747: Fuzzy filename search for Baloo

michaeleden added a comment. @bruns should I continue with this implementation and add dbs and such? And do the tests make sense? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13747 To: michaeleden, vhanda, #baloo Cc: bruns, kde-frameworks-devel, #baloo,

D13747: Fuzzy filename search for Baloo

michaeleden updated this revision to Diff 36811. michaeleden added a comment. Add fuzzy search class separate from db and make tests to demonstrate algorithm REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13747?vs=36724=36811 BRANCH feature/fuzzy-search

D13747: Fuzzy filename search for Baloo

bruns added a comment. In D13747#283539 , @michaeleden wrote: > @bruns decoupling makes sense, but eventually there will be a need for a db right? > And I will definitely make those test cases, but I may ask for some help on how they're

D13747: Fuzzy filename search for Baloo

michaeleden added a comment. @bruns decoupling makes sense, but eventually there will be a need for a db right? And I will definitely make those test cases, but I may ask for some help on how they're done in baloo. REPOSITORY R293 Baloo REVISION DETAIL

D13747: Fuzzy filename search for Baloo

bruns added a comment. I would very much prefer a test driven approach here: - Write down in english prosa what you want to match - Create some test cases - Add implementation classes Up to this point, you don't need any real database, QMap or std::map will do. Decoupling this

D13747: Fuzzy filename search for Baloo

michaeleden added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13747 To: michaeleden, vhanda, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13747: Fuzzy filename search for Baloo

michaeleden created this revision. michaeleden added a reviewer: vhanda. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. michaeleden requested review of this revision. REVISION SUMMARY This is a proof of concept