D13782: Ignore NTFS hidden flag for root volume

2018-08-09 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > wbauer wrote in file_unix.cpp:567 > This still doesn't handle symlinks. > E.g. if you create a symlink to the NTFS partition's mount point/root dir on > your desktop, it will still be hidden. > > As mentioned, `const QString fullFilePath = QDir(f

D13782: Ignore NTFS hidden flag for root volume

2018-08-09 Thread Wolfgang Bauer
wbauer added inline comments. INLINE COMMENTS > file_unix.cpp:567 > +if (ep->d_type == DT_DIR || ep->d_type == DT_UNKNOWN) { > +const QString fullFilePath = > QDir::cleanPath(QDir().absoluteFilePath(filename)); > +auto mountPoin

D13782: Ignore NTFS hidden flag for root volume

2018-08-09 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f6df95e595ee: Ignore NTFS hidden flag for root volume (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13782?vs=39331&id=39332 REVISION DETAIL h

D13782: Ignore NTFS hidden flag for root volume

2018-08-09 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, yurikoles, bruns Cc: ngraham, oysteins, wbauer, kde-frameworks-devel, michaelh, bruns

D13782: Ignore NTFS hidden flag for root volume

2018-08-08 Thread Kai Uwe Broulik
broulik updated this revision to Diff 39331. broulik retitled this revision from "RFC: Ignore NTFS hidden flag for root volume" to "Ignore NTFS hidden flag for root volume". broulik added a comment. - Rebase - use `QDir().absoluteFilePath()` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE