dhaumann added a comment.
Late to the game, but also +1 from me.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13884
To: broulik, #frameworks, rjvbb, ngraham, cfeck
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
broulik closed this revision.
broulik added a comment.
https://cgit.kde.org/kwidgetsaddons.git/commit/?id=ea282678c937e0e376b391560c585e835528870f
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13884
To: broulik, #frameworks, rjvbb, ngraham, cfeck
Cc:
broulik added inline comments.
INLINE COMMENTS
> rjvbb wrote in kmessagewidget.cpp:57
> Nitpick: shouldn't this be called `setStyleSheet` or something similar that
> indicates a bit better that it defines the stylesheet itself?
It doesn't take any arguments, so I explicitly did not call it
ngraham accepted this revision.
ngraham added a comment.
Thanks, works as expected and I couldn't find any regressions. Code looks
good.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13884
To: broulik, #frameworks, rjvbb, ngraham, cfeck
Cc:
rjvbb accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13884
To: broulik, #frameworks, rjvbb, ngraham, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
rjvbb added a comment.
Otherwise LGTM (I also checked the in-app palette change myself: seems to
work fine).
INLINE COMMENTS
> kmessagewidget.cpp:57
> void createLayout();
> +void applyStyleSheet();
> void updateSnapShot();
Nitpick: shouldn't this be called `setStyleSheet` or
broulik updated this revision to Diff 37144.
broulik added a comment.
- Juggle it around a bit
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13884?vs=37143=37144
REVISION DETAIL
https://phabricator.kde.org/D13884
AFFECTED FILES
broulik edited the test plan for this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13884
To: broulik, #frameworks, rjvbb, ngraham, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
broulik edited the summary of this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13884
To: broulik, #frameworks, rjvbb, ngraham, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
broulik created this revision.
broulik added reviewers: Frameworks, rjvbb, ngraham, cfeck.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
The colors are hardcoded
10 matches
Mail list logo
