D13921: Don't show confirmation dialog for Trash action by default

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7d15dad5e427: Don't show confirmation dialog for Trash action by default (authored by aleksejshilin). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13921?vs=37242&id=3

D13921: Don't show confirmation dialog for Trash action by default

aleksejshilin edited the summary of this revision. REPOSITORY R241 KIO BRANCH dont_confirm_trash REVISION DETAIL https://phabricator.kde.org/D13921 To: aleksejshilin, dfaure, #frameworks, #dolphin, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13921: Don't show confirmation dialog for Trash action by default

aleksejshilin added a comment. In D13921#288012 , @ngraham wrote: > There's a problem with the git setup on the computer you used to make this commit; the `name` field appears to be empty, so I get an error when I try to apply the patch

D13921: Don't show confirmation dialog for Trash action by default

ngraham accepted this revision. ngraham added a comment. Perfect! Do you have commit access yet? REPOSITORY R241 KIO BRANCH dont_confirm_trash REVISION DETAIL https://phabricator.kde.org/D13921 To: aleksejshilin, dfaure, #frameworks, #dolphin, ngraham Cc: ngraham, kde-frameworks-

D13921: Don't show confirmation dialog for Trash action by default

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. In D13921#288014 , @ngraham wrote: > Are you planning to update `konqueror/settings/konq/behaviour.cpp` as the comment asked? ;) AFAIC

D13921: Don't show confirmation dialog for Trash action by default

ngraham added reviewers: Frameworks, Dolphin. ngraham added a comment. The actual code change looks sane and fixes the bug. Are you planning to update `konqueror/settings/konq/behaviour.cpp` as the comment asked? ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13

D13921: Don't show confirmation dialog for Trash action by default

ngraham added a comment. There's a problem with the git setup on the computer you used to make this commit; the `name` field appears to be empty, so I get an error when I try to apply the patch: Created and checked out branch arcpatch-D13921. Checking patch src/widgets/jobuidelegat

D13921: Don't show confirmation dialog for Trash action by default

aleksejshilin created this revision. aleksejshilin added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Dolphin and KIO default confirmation