This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0a39f67256b3: Add syntax highlighting support for Stan
(authored by cullmann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D13940?vs=37388=39723#toc
REPOSITORY
R216 Syntax Highlighting
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Restricted Application added a project: Kate.
Restricted Application added a subscriber: kwrite-devel.
Looks ok, should I push that for you as "Jeffrey Arnold
"?
REPOSITORY
R216
jeffreyarnold added a comment.
Great! I just updated the patch. Sorry about the first patch. Not an
excuse, but it got lost with the number of new untracked files created during
the build and testing processes. Should I create another patch (different
issue) that would update the
jeffreyarnold updated this revision to Diff 37388.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13940?vs=37303=37388
REVISION DETAIL
https://phabricator.kde.org/D13940
AFFECTED FILES
autotests/folding/highlight.stan.fold
dhaumann added a comment.
Looks already pretty good to me, but indeed highlight.stan is missing - the
test file for the autotest. Could you add it and update the patch?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D13940
To: jeffreyarnold,
pino added a comment.
It looks like your forgot to include the actual `highlight.stan` file for the
test suite, can you please amend this commit to include it?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D13940
To: jeffreyarnold,
jeffreyarnold created this revision.
jeffreyarnold added a reviewer: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jeffreyarnold requested review of this revision.
REVISION SUMMARY
Add syntax