dhaumann added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:137
>
> -if (path.endsWith(QLatin1String("/documents"))) {
> -searchUrl = searchUrlForType(QStringLiteral("Document"));
> -} else if (path.endsWith(QLatin1String("/images"))) {
> -
dfaure added a comment.
This change broke KFilePlacesViewTest, please update that test as well.
$ bin/kfileplacesviewtest
- Start testing of KFilePlacesViewTest *
Config: Using QtTest library 5.11.1, Qt 5.11.1 (x86_64-little_endian-lp64
shared (dynamic) debug build; by
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3523ba575b39: [KFilePlacesModel] Support pretty
baloosearch URLs (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14043?vs=37553=37858
REVISION
hein accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14043
To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, ngraham, hein
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Tested with a new and existing user. Entries in Kickoff, Dolphin, Gwenview,
and the file dialogs all work perfectly, and the subtitles in Kickoff are
pretty. Code looks sane.
REPOSITORY
broulik edited the test plan for this revision.
broulik added a dependency: D14042: Support special URLs for finding files of a
certain type.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14043
To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, ngraham,
broulik created this revision.
broulik added reviewers: Frameworks, bruns, dfaure, renatoo, franckarrecot,
ngraham, hein.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION
