D14160: [KMessageBox] Call style for icon

2018-07-16 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: dfaure, kfunk. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `QMessageBox::standardIcon` is deprecated. Also,

D14160: [KMessageBox] Call style for icon

2018-07-16 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. In general, looks good to me. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D14160 To: broulik, dfaure, kfunk, dhaumann Cc: dhaumann, kde-frameworks-de

D14160: [KMessageBox] Call style for icon

2018-07-17 Thread Henrik Fehlauer
rkflx added a comment. > Dialog icons are correct on Linux with Breeze …if you also apply D14161 . Otherwise LGTM. > This needs testing on Windows and Mac You could add or ping more reviewers who happen to have a dev setup on those platforms,

D14160: [KMessageBox] Call style for icon

2018-08-08 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R236:c6be3760ecd0: [KMessageBox] Call style for icon (authored by broulik). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14160?vs=37883&id=39288 REVISION DETAI