D14175: Support cursor hints on locked pointer

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Implement support for locked pointer cursor hints. TE

D14175: Support cursor hints on locked pointer

romangg updated this revision to Diff 37917. romangg added a comment. - Cleanup: remove hint getter REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14175?vs=37916&id=37917 BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175 AFFECTED

D14175: Support cursor hints on locked pointer

romangg added a task: T4692: [kwayland] Support cursor hint on LockedPointerInterface. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

romangg added a dependent revision: D14176: Use locked cursor position hint. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

romangg updated this revision to Diff 37938. romangg added a comment. - Add autotest REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14175?vs=37917&id=37938 BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175 AFFECTED FILES autote

D14175: Support cursor hints on locked pointer

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_pointer_constraints.cpp:258 > +QVERIFY(hintChangedSpy.wait()); > + > // and unlock again We should check the value of hintChange

D14175: Support cursor hints on locked pointer

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in pointerconstraints_interface.h:126 > do we not want a getter method? > > One of kwayland's main roles is to be a property cache The hint is used by the compositor after unlock again. This unlock can also happen on destruc

D14175: Support cursor hints on locked pointer

romangg updated this revision to Diff 37971. romangg added a comment. - Add hint getter - Add since keyword REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14175?vs=37938&id=37971 BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175

D14175: Support cursor hints on locked pointer

romangg marked 4 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

romangg edited the summary of this revision. romangg edited the test plan for this revision. REPOSITORY R127 KWayland BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bru

D14175: Support cursor hints on locked pointer

This revision was automatically updated to reflect the committed changes. Closed by commit R127:cebfd2f8d2f9: Support cursor hints on locked pointer (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14175?vs=37971&id=38231#toc REPOSITORY R127 KWayland CHANGES SINCE