apol abandoned this revision.
apol added a comment.
Doesn't seem relevant anymore
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: dfaure, ngraham, andreask, kde-frameworks-devel, LeGast00n,
ngraham added a comment.
@apol we have a duplicate test in breeze-icons now; is this still relevant?
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: dfaure, ngraham, andreask,
dfaure added inline comments.
INLINE COMMENTS
> kiconloaderdummy.h:1
> +#ifndef KICONLOADERDUMMY_H
> +#define KICONLOADERDUMMY_H
copyright header missing
> kiconloaderdummy.h:9
> +#include
> +#include
> +
This includes all of QtTest *plus* all of QtCore. Prefer
REPOSITORY
R266 Breeze
apol added a comment.
@andreask, thanks for looking into it. Now it's accepted but we'll get a
bunch of errors, how do you suggest we resolve it? I'd rather have a plan
before landing this.
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14218
andreaska accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: ngraham, andreask, kde-frameworks-devel, michaelh,
ngraham added a comment.
+1 conceptually.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: ngraham, andreask, kde-frameworks-devel, michaelh, bruns
ngraham edited reviewers, added: Breeze, Frameworks; removed: Framework: Syntax
Highlighting.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause, #breeze, #frameworks,
#framework_syntax_highlighting
Cc: andreask,
mart added a comment.
+100 from me as well
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting
Cc: andreask, kde-frameworks-devel, michaelh, ngraham, bruns
apol added a subscriber: andreask.
apol added a comment.
Can someone from the breeze team confirm the issue? If so I'll help find a
solution.
@andreask?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause,
vkrause added a comment.
+1 on the test, can't comment on how to resolve this unfortunately
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting
Cc: kde-frameworks-devel, michaelh, ngraham,
apol edited the test plan for this revision.
apol added reviewers: andreaska, mart, vkrause, Framework: Syntax Highlighting.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting
Cc:
apol created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
At the moment we have them separate in actions, places, applications. This
distinction is
12 matches
Mail list logo