broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
We use the `KDirWatch` singleton so we migh
lbeltrame added a comment.
+1
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14395
To: broulik, #frameworks, dfaure
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Well spotted.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14395
To: broulik, #frameworks, dfaure
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a9b4eded78e8: [KSambaShare] Check file that's
changed before reloading (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14395?vs=38479&id=38508
RE
ngraham added a comment.
Could this have fixed https://bugs.kde.org/show_bug.cgi?id=394764?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14395
To: broulik, #frameworks, dfaure
Cc: ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns
broulik added a comment.
Unlikely
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14395
To: broulik, #frameworks, dfaure
Cc: ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns
