D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

apol created this revision. apol added reviewers: leinir, whiting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's just not overloaded by QStringList, so we keep a l

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Does this really make a difference? Also... fix qt to get QStringList::containst(QStringRef)? REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D144

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

apol added a comment. In D14401#298611 , @aacid wrote: > Does this really make a difference? I was looking at heaptrack and this function was a point of contention, maybe not a big deal. > Also... fix qt to get QStringList::containst

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

This revision was automatically updated to reflect the committed changes. Closed by commit R235:1b7564fabf2b: Don't instantiate a QStringRef into a QString only to search in a QStringList (authored by apol). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14401?

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

bruns added inline comments. INLINE COMMENTS > parser.cpp:58 > parseMetadataXml(xml); > -} else if (elements.contains(xml.name().toString())) { > +} else if (stringList_contains_stringRef(elements, xml.name())) { > item = parseXml(xml); Y