dhaumann added a comment.
Thanks for the info - I will look into this again later.
I can see that it's code duplication, but strictly speaking the case
statement of StartElement and EndElement are now more "symmetric".
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
winterz added a comment.
agree that Q_FALLTHROUGH(); is a better idea.
it doesn't duplicate code and it informs the reader that the fallthrough is
intentional
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14524
To: dhaumann, vkrause
Cc: winterz,
aacid added a comment.
Maybe it makes more sense to replace it with the magic words?
// fall-through
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14524
To: dhaumann, vkrause
Cc: aacid, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7312f52e2753: Fix compiler warning -Wimplicit-fallthrough
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14524?vs=38873=38874
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
removeWarnings (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D14524
To: dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh,
dhaumann added a comment.
If there is a better / more readable fix, please let me know.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14524
To: dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking,
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.
REVISION SUMMARY
