dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.
REVISION SUMMARY
Hide more implementation details and make InlineNote more exten
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
I think that is ok, but one should remove column(), isValid() and == (which
is no equal anyways ATM).
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.o
dhaumann updated this revision to Diff 39909.
dhaumann added a comment.
- Cleanup InlineNote interface
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14897?vs=39907&id=39909
BRANCH
inline-note-data (branched from master)
REVISION DETAIL
https://pha
dhaumann updated this revision to Diff 39910.
dhaumann added a comment.
- Remove default constructor, not implemented anyways
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14897?vs=39909&id=39910
BRANCH
inline-note-data (branched from master)
REVISI
cullmann accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R39 KTextEditor
BRANCH
inline-note-data (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D14897
To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapav
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:4e279cd72493: InlineNote: Pimpl inline note data without
allocs (authored by dhaumann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14897?vs=39911&id=39912
RE
dhaumann updated this revision to Diff 39911.
dhaumann added a comment.
- Rename InlineNote::hasFocus() to underMouse()
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14897?vs=39910&id=39911
BRANCH
inline-note-data (branched from master)
REVISION DET
brauch added a comment.
Looks ok to me, except one thing: the operator== is used to compare a note
from the list to the "currently active" note in the view. If this compares also
the "under mouse" state, this code might be broken now ...?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https
dhaumann added a comment.
Can you annotate the code here that you think is wrong?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D14897
To: dhaumann, cullmann
Cc: brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,
bruns, demsking, cullman
brauch added a comment.
Sorry, never mind -- that code I removed yesterday. All should be fine.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D14897
To: dhaumann, cullmann
Cc: brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,
bruns, de
10 matches
Mail list logo