D14899: [KUrlComboBox] Fix KIcon porting error

2018-08-17 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:64ba67d0acc4: [KUrlComboBox] Fix KIcon porting error (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14899?vs=39913&id=39914 REVISION DETAIL ht

D14899: [KUrlComboBox] Fix KIcon porting error

2018-08-17 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Whoops REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14899 To: broulik, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14899: [KUrlComboBox] Fix KIcon porting error

2018-08-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14899 To: broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14899: [KUrlComboBox] Fix KIcon porting error

2018-08-17 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It should be using `QIcon::fromTheme` TEST PLAN I don't actually know where this ic