D15002: Allow to install syntax files instead of having them in a resource

cullmann closed this revision. cullmann added a comment. If somebody has an fix for the CMake thingy, please open a new diffusion for that. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause, dhaumann Cc: kfunk, dhaumann, kwrite-

D15002: Allow to install syntax files instead of having them in a resource

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. If you have ideas how, patches are welcome. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause, dhaumann Cc: kfunk, dhauma

D15002: Allow to install syntax files instead of having them in a resource

kfunk added inline comments. INLINE COMMENTS > CMakeLists.txt:3 > macro(generate_php_syntax_definition targetFile srcFile) > -add_custom_command( > -OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${targetFile} > -COMMAND ${PERL_EXECUTABLE} > ${CMAKE_CURRENT_SOURCE_DIR}/generators/genera

D15002: Allow to install syntax files instead of having them in a resource

This revision was automatically updated to reflect the committed changes. Closed by commit R216:59ddf56f98d9: Allow to install syntax files instead of having them in a resource (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D15002: Allow to install syntax files instead of having them in a resource

dhaumann accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars

D15002: Allow to install syntax files instead of having them in a resource

cullmann requested review of this revision. cullmann added a comment. Updated patch to allow make test to work. REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullma

D15002: Allow to install syntax files instead of having them in a resource

cullmann updated this revision to Diff 40242. cullmann added a comment. Update that allows make test to succeed, even before one does make install. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15002?vs=40232&id=40242 REVISION DETAIL https://phabricator.kde.org/D15002

D15002: Allow to install syntax files instead of having them in a resource

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. makes sense REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, k

D15002: Allow to install syntax files instead of having them in a resource

dhaumann added a comment. BTW, slightly related as idea: I think it would be nice to add a function Definition Downloader::setDownloadLocation() or similar that allows to have a custom download location. This would match nicely with Repository::addCustomSearchPath(). REPOSITORY R216 Synta

D15002: Allow to install syntax files instead of having them in a resource

dhaumann added a comment. I am fine with this change. I want a review from Volker, through . REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bru

D15002: Allow to install syntax files instead of having them in a resource

cullmann created this revision. cullmann added a reviewer: vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY Given the license of some files is dubious, this allows MIT lovi