D15340: Add Solarized Light and Dark themes

acrouthamel added a comment. I just realized the output was HTML. Ok, I can see what is going on now. If you could let me know if I am missing the "code-editor" though, that would be great! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To: acrou

D15340: Add Solarized Light and Dark themes

acrouthamel added a comment. In D15340#322631 , @dhaumann wrote: > Sure, please use kdesrc-build as described here: > https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source > > Once setup, you can build everything by invoking ./k

D15340: Add Solarized Light and Dark themes

dhaumann added a comment. Sure, please use kdesrc-build as described here: https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source Once setup, you can build everything by invoking ./kdesrc-build You can also pass a module to build: ./kdesrc-build syntax-highlighting

D15340: Add Solarized Light and Dark themes

acrouthamel added a comment. In D15340#322453 , @dhaumann wrote: > Btw, we forgot to add the themes to the Qt resource file, see also D15358 > > You can test the theme with the demo app in ksyntaxhighlight

D15340: Add Solarized Light and Dark themes

acrouthamel added a comment. Thanks, I'll make sure to add to that file if I add more themes. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks

D15340: Add Solarized Light and Dark themes

dhaumann added a comment. Btw, we forgot to add the themes to the Qt resource file, see also D15358 You can test the theme with the demo app in ksyntaxhighlighting: Go to the build-directory, then type ./bin/codeeditor Then, you can switch the them

D15340: Add Solarized Light and Dark themes

dhaumann added a comment. See D15358 :-) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortime

D15340: Add Solarized Light and Dark themes

acrouthamel added a comment. In D15340#322112 , @dhaumann wrote: > Looks good to me. > > Related: in order to have better unit testing, would you be willing to add a unit test to https://github.com/KDE/syntax-highlighting/blob/master/autotes

D15340: Add Solarized Light and Dark themes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6d26c25fcfda: Add Solarized Light and Dark themes (authored by acrouthamel). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15340?vs=41179&id=41216 REV

D15340: Add Solarized Light and Dark themes

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. Related: in order to have better unit testing, would you be willing to add a unit test to https://github.com/KDE/syntax-highlighting/blob/master/autotests/theme_t

D15340: Add Solarized Light and Dark themes

acrouthamel edited the summary of this revision. acrouthamel added reviewers: Kate, Framework: Syntax Highlighting. acrouthamel added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To: acrouthamel, #kate, #fra

D15340: Add Solarized Light and Dark themes

acrouthamel created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. acrouthamel requested review of this revision. REVISION SUMMARY This adds Solarized Light and Dark themes, with the same color scheme selected in Phabricato