jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.
REVISION SUMMARY
This fixes all texts being displayed as Text.PlainText if not explicitly
overriden.
REPOSITORY
R242 Plasma Fra
ngraham added a reviewer: Plasma.
ngraham added a comment.
Is there a reason for this change, or a bug report that it fixes? How have
you tested this? Do any visual changes result from this patch? If so, are they
all desirable? Etc. Some more information would be nice.
REPOSITORY
R242 Plas
svuorela added a comment.
I think it is undesireable to change the default, because all users are now
used to having it PlainText, so they are now dumping
things-that-looks-like-html into it and expecting it to be plaintext.
so all users of Label that don't have textFormat set now needs
jbbgameich added a comment.
@ngraham I noticed the issue when using the QtQuickControls 2 style. All
other styles I know don't require setting the textFormat, only the Plasma
Style. Of course all QQC2 applications could just set the textFormat, but it's
not possible in all cases. For example
ngraham added a comment.
What app/plasmoid/widget is that a screenshot from? It might make more sense
to just set the text format there, rather than universally.
P.S. you can attach screenshots to comments here so they appear inline.
REPOSITORY
R242 Plasma Framework (Library)
REVISION
jbbgameich added a comment.
@ngraham The screenshot is from Kaidan. It's using QtQuickControls 2 with the
Plasma Style, so not PlasmaComponents direcltly. I don't think it's possible to
set the textFormat for this tooltip in QtQuickControls 2 unfortunately.
@svuorela So it seems like app
ngraham added a comment.
Should Applications really be using Plasma style and components? I think they
probably should be using desktop QQC2 style via Kirigami instead.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D15364
To: jbbgameich, #plasma
jbbgameich added a comment.
On Plasma Mobile all applications use the Plasma Style for QtQuickControls 2.
(kaidan is also a Plasma Mobile application)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D15364
To: jbbgameich, #plasma
Cc: svuorela, ngra
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
You're absolutely right this is wrong.
> @sune
It is a crap default, but it shouldn't change per theme when a user is using
Qqc2 directly. They might develop for th
jbbgameich added a comment.
@davidedmundson I'm not yet used to the KDE Phabricator workfolow... do I
need to do anything else to get this patch landed / included?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D15364
To: jbbgameich, #plasma, davi
broulik added a comment.
I thought we did that consciously and intentionally since we could break
compat here and the `AutoText` which tries to guess from the contents and even
allows injecting `img` was something we wanted to avoid?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DET
jbbgameich closed this revision.
jbbgameich added a comment.
I think this was fixed in another way already.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D15364
To: jbbgameich, #plasma, davidedmundson
Cc: broulik, davidedmundson, svuorela, ngraham
12 matches
Mail list logo
