This revision was automatically updated to reflect the committed changes.
Closed by commit R240:9b528012703a: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT
as default compile flags (authored by mlaurent).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
add_QT_NO_NARROWING_CONVERSIONS_IN_CONNECT
REVISION DETAIL
https://phabricator.kde.org/D15566
To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem,
mlaurent added a comment.
Ping?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15566
To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
mlaurent added a comment.
I fixed 2 repos.
Otherwise all compiles fine (ok I don't test on windows/mac and perhaps some
module is not compiles on my computer)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15566
To: mlaurent, dfaure
Cc:
dfaure added a comment.
Do all frameworks build with this change?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15566
To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
mlaurent created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
Use QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default flags
REPOSITORY
R240 Extra
mlaurent added a reviewer: dfaure.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15566
To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns