D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY as pointed out in D13700

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Alexander Stippich
astippich added a comment. The removal of the convertWCharsToQString function is safe, right? It was never exported REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15614 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15614 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Matthieu Gallien
mgallien added a comment. In D15614#328722 , @astippich wrote: > The removal of the convertWCharsToQString function is safe, right? It was never exported It is a static function. So it is absolutely safe to remove it. REPOSITORY R286

D15614: remove usage of own TString to QString conversion function

2018-09-22 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH taglib_extractor_string_conversion REVISION DETAIL https://phabricator.kde.org/D15614 To: astippich, bruns, mgallien, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhn

D15614: remove usage of own TString to QString conversion function

2018-09-23 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:4c760d4588f3: remove usage of own TString to QString conversion function (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15614?vs=4196