sdepiets closed this revision.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D15686
To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15686
To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
sdepiets updated this revision to Diff 42121.
sdepiets added a comment.
Coding style
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15686?vs=42120&id=42121
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15686
AFFECTED FILES
src/ui/highli
dfaure added a comment.
Makes sense.
INLINE COMMENTS
> highlighter.cpp:198
> +if (cursor.hasSelection())
> +{
> +cursor.clearSelection();
coding style: join with previous line
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D15686
To: sde
sdepiets edited the summary of this revision.
sdepiets added reviewers: Framework: Syntax Highlighting, mlaurent, dfaure.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D15686
To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure
Cc: kde-frameworks-devel, michael
sdepiets created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sdepiets requested review of this revision.
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15686
AFFECTED FILES
src/ui/highlighter.cpp
