D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:52920c0003d6: move testing of common tags of test files to a new data-driven test for… (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH refactor_taglib_extractor_tests REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Thanks for the explanation. Looks good then, just update the summary. You could add another column to the tests, "hasFullImplementation", and do an Q_EXPECT_FAIL if not set. But thats

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a comment. Sorry, I should have written this more clearly, but you got it right. It's for the new formats. For the most common tags, taglib directly provides the implementation for all its supported tag formats and one can call e.g. tag->artist(). For the others, one has to

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

bruns added a comment. In D15825#338218 , @astippich wrote: > In D15825#334087 , @bruns wrote: > > > There are some more common tags with identical values, i.e. AlbumArtist, Composer and Lyrics -

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a comment. In D15825#334087 , @bruns wrote: > There are some more common tags with identical values, i.e. AlbumArtist, Composer and Lyrics - any reason you kept these? These are the tags directly supported by taglib (e.g.

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich updated this revision to Diff 43028. astippich added a comment. - explicitly test for supported mimetype REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15825?vs=42529=43028 BRANCH refactor_taglib_extractor_tests REVISION DETAIL

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

bruns added a comment. There are some more common tags with identical values, i.e. AlbumArtist, Composer and Lyrics - any reason you kept these? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel,

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a dependent revision: D15833: extend test coverage to all supported mimetypes for taglibextractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich created this revision. astippich added reviewers: bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY as a preparation for more test data, move all tags that