D15829: make units and prefixes of formatValue translatable

This revision was automatically updated to reflect the committed changes. Closed by commit R244:0b58dc656d1a: make units and prefixes of formatValue translatable (authored by astippich). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=43038&id=4698

D15829: make units and prefixes of formatValue translatable

astippich added a comment. If no-one objects or has any comments regarding coding, I'm going to land this revision in one week REPOSITORY R244 KCoreAddons BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 To: astippich, bruns, safaalfulaij Cc: kde-frameworks-d

D15829: make units and prefixes of formatValue translatable

astippich added a comment. ping REPOSITORY R244 KCoreAddons BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 To: astippich, bruns, safaalfulaij Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 43038. astippich added a comment. - fixup spaces REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=43034&id=43038 BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 AFFECTED FIL

D15829: make units and prefixes of formatValue translatable

astippich added a comment. In D15829#338296 , @safaalfulaij wrote: > Thanks! > I think this solved all my issues. I can for meter unit change the formatting so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and choose to keep the

D15829: make units and prefixes of formatValue translatable

safaalfulaij added inline comments. INLINE COMMENTS > kformatprivate.cpp:124 > +{ KFormat::UnitPrefix::Milli, 1e-3, bpow(-10), tr("m", "SI prefix > for 10^⁻3") , QString() }, > +{ KFormat::UnitPrefix::Unity, 1.0, 1.0 , QString() > , QString()}, > +

D15829: make units and prefixes of formatValue translatable

safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Thanks! I think this solved all my issues. I can for meter unit change the formatting so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and choose to keep the dot o

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 43034. astippich added a comment. - add seperate, translatable string for IEC binary prefixes REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=42563&id=43034 BRANCH translate_units REVISION DETAIL htt

D15829: make units and prefixes of formatValue translatable

astippich added inline comments. INLINE COMMENTS > safaalfulaij wrote in kformatprivate.cpp:168 > Well, I searched other languages and no one seems to do as Arabic does. We do > not abbreviate in this case and just write the whole "Mebi.Byte" ("Byte" is > always written, "M.Byte" > "MB"). > And

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 42563. astippich added a comment. - change description for prefixes and make the IEC prefix translatable REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=42542&id=42563 BRANCH translate_units REVISION D

D15829: make units and prefixes of formatValue translatable

safaalfulaij added a comment. I came into anther problem, this time with the unit selection. In Arabic, we don't put a dot between the prefix and the unit if we're talking about meters (mm, cm, km), but we do with other units (k.Byte, M.Byte, G.Byte). If ki18n was used here, all of thi

D15829: make units and prefixes of formatValue translatable

astippich added a comment. In D15829#333799 , @safaalfulaij wrote: > Since the joining between number and format is translatable, that's great. I meant that if it is kept untranslatable, problems regarding RTL will happen. Sorry, I don't

D15829: make units and prefixes of formatValue translatable

safaalfulaij added a comment. Since the joining between number and format is translatable, that's great. I meant that if it is kept untranslatable, problems regarding RTL will happen. INLINE COMMENTS > kformatprivate.cpp:115 > const PrefixMapEntry map[] = { > -{ KFormat::UnitPre

D15829: make units and prefixes of formatValue translatable

astippich added a comment. @bruns please have a look at the changes. In particular, regarding "µ" and windows support. I don't know if this will be able to compile on windows, or how to fix it for tr() function. @safaalfulaij please verify if this fixes the RTL issue for you REPOSITORY R

D15829: make units and prefixes of formatValue translatable

astippich created this revision. astippich added reviewers: bruns, safaalfulaij. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY give the possibility to translate the prefix und unit strings REPOS