D15909: Fix compile failure on Windows targets

2018-10-03 Thread Christophe Giboudeaux
This revision was automatically updated to reflect the committed changes. Closed by commit R246:2e364ebbf240: Fix compile failure on Windows targets (authored by zrax, committed by cgiboudeaux). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D15909: Fix compile failure on Windows targets

2018-10-03 Thread Michael Hansen
zrax added a comment. No, I do not have push permissions. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15909 To: zrax, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15909: Fix compile failure on Windows targets

2018-10-03 Thread Dominik Haumann
dhaumann added a comment. Btw, can you commit yourself, or shall we push this? If so, can someone take care of this, since I am not available for the next 10 days. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15909 To: zrax, dhaumann Cc: dhaumann,

D15909: Fix compile failure on Windows targets

2018-10-03 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15909 To: zrax, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15909: Fix compile failure on Windows targets

2018-10-02 Thread Michael Hansen
zrax created this revision. Herald added a project: Frameworks. zrax requested review of this revision. REVISION SUMMARY Fix a compile failure on Windows due to the use of QSysInfo enums which are not fully qualified. REPOSITORY R246 Sonnet REVISION DETAIL