D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-12 Thread Igor Poboiko
poboiko added a comment. That's weird. I caught it only once and thought that it is because I trivially forgot the endl. But now I cannot reproduce it anymore. Seems like it should be fine, since we do emit finished signal, which will write the 'OK' part. Sorry for the noise. REVISION DE

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-12 Thread Stefan Brüns
bruns added a comment. Also, is your running baloo_file using current master? Otherwise, it may return a file finished long ago, see D15994 . REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: ngraham

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-12 Thread Stefan Brüns
bruns added a comment. In D15985#341854 , @poboiko wrote: > Indexing /some/file1Indexing /some/file2: OK > Are you sure its file1...file2 and not the same file twice? If it is the same, we can set m_currentFile in 71 and suppress the

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-12 Thread Stefan Brüns
bruns added a comment. In D15985#341854 , @poboiko wrote: > In D15985#341811 , @bruns wrote: > > > No, definitely not, see D15995 . > > > I don't see how it i

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-12 Thread Igor Poboiko
poboiko added a comment. In D15985#341811 , @bruns wrote: > No, definitely not, see D15995 . I don't see how it is a problem. The problem is not that it's not written to terminal (it is), but that it ju

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-12 Thread Stefan Brüns
bruns added a comment. In D15985#341751 , @poboiko wrote: > Woops! `startedIndexingFile` does not print a newline. I guess I can just add `m_out << endl`... No, definitely not, see D15995 . REVISION DE

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-12 Thread Igor Poboiko
poboiko added a comment. Woops! `startedIndexingFile` does not print a newline. I guess I can just add `m_out << endl`... REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-08 Thread Igor Poboiko
poboiko closed this revision. REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Fantastic! Works great. BRANCH monitor-initial-state (branched from master) REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-06 Thread Stefan Brüns
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Looks sane ... BRANCH monitor-initial-state (branched from master) REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns Cc: bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-06 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. poboiko requested review of this revision. REVISION SUMMARY This is based on D15943: [balooctl] Monitor also for state changes . Simply print current state & file when monitor starts