D16018: Fix align of doxygen comments in templates

dhaumann added a comment. Yes, in KDE Frameworks, there is only a master branch. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor, dhaumann Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking,

D16018: Fix align of doxygen comments in templates

buschinski closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor, dhaumann Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sars, dhaumann

D16018: Fix align of doxygen comments in templates

buschinski updated this revision to Diff 44010. buschinski retitled this revision from "Fix align of doxygen comments" to "Fix align of doxygen comments in templates". buschinski removed a project: KDevelop. buschinski removed a subscriber: kdevelop-devel. buschinski added a comment. -

D16018: Fix align of doxygen comments

buschinski added a comment. Thx for the review :) I will update the patch (and post it here again). I can commit it myself, to master? or any special branch? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor, dhaumann Cc:

D16018: Fix align of doxygen comments

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Well, make test works for me, and if this fixes the issue for you, I'm fine with that. Locally, I had to resolve one hunk that did not apply. Maybe you have to update the patch

D16018: Fix align of doxygen comments

cullmann added a reviewer: dhaumann. cullmann added a comment. Dominik is more well versed in cstyle.js ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor, dhaumann Cc: kdevelop-devel, cullmann, kwrite-devel,

D16018: Fix align of doxygen comments

buschinski updated this revision to Diff 43201. buschinski added a comment. Changed to (correct) ktexteditor repository. Someday... I will learn how to use phabricator :) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16018?vs=43088=43201 REVISION

D16018: Fix align of doxygen comments

buschinski changed the repository for this revision from R32 KDevelop to R39 KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, antismap,

D16018: Fix align of doxygen comments

buschinski added a comment. This did not work for templates as "isComment" uses line attributes and at the time the template is inserted it is always "C/C++ Code/Data"-attribute never a comment. It only becomes a "doxygen comment"-attribute after the template "editing" is finished.

D16018: Fix align of doxygen comments

buschinski updated this revision to Diff 43088. buschinski edited the summary of this revision. buschinski edited the test plan for this revision. Herald added a project: KDevelop. Herald added a subscriber: kdevelop-devel. REPOSITORY R32 KDevelop CHANGES SINCE LAST UPDATE

D16018: Fix align of doxygen comments

buschinski added a comment. In D16018#338441 , @cullmann wrote: > ... > For the code: > Hmm, why do you use rtrim? That removes trailing spaces, that won't help the startsWith checks. Or do I misread that? You are absolutely right,

D16018: Fix align of doxygen comments

cullmann added a comment. Hi, thanks for the patch to improve the indentation handling. A case to reproduce would help. For me, the identation is messed up in Kate if I do indent/unindent of such comments and the "keep extra spaces" option is off. But I think that has nothing to do with

D16018: Fix align of doxygen comments

buschinski created this revision. buschinski added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. buschinski requested review of this revision. REVISION SUMMARY After https://bugs.kde.org/show_bug.cgi?id=360456