alexde abandoned this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16049
To: alexde, #vdg, ngraham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham added a comment.
No problem at all, just Abandon this one (available via the Add Action...
button on the bottom of the page.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16049
To: alexde, #vdg, ngraham, #frameworks
Cc: kde-frameworks-devel, michaelh,
alexde added a comment.
> Also, you might want to set up arc, which makes it much simpler and faster
to submit patches, and easier for me too.
I tried it again, but I forgot to add the "Differential Revision" and did not
expect //arc diff// to automatically upload the diff. That is why
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
This doesn't apply cleanly:
Checking patch src/filewidgets/kfileplacesview.cpp...
Hunk #1 succeeded at 745 (offset 3 lines).
error: while searching for:
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16049
To: alexde, #vdg, ngraham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham added a reviewer: Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16049
To: alexde, #vdg, ngraham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
alexde created this revision.
alexde added reviewers: VDG, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alexde requested review of this revision.
REVISION SUMMARY
The items "Hide", "Hide Entry" and "Show All Entries" of the places panel
did not
