astippich created this revision.
astippich added reviewers: mgallien, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
add some more tags for asf audio files
REPOSITORY
R286 KF
astippich added a comment.
for some reason the TagLib::ASF::File tag() function returns only an invalid
pointer, so I decided to use the dynamic_cast here.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16283
To: astippich, mgallien, bruns
Cc: kde-frameworks-
bruns added inline comments.
INLINE COMMENTS
> taglibextractor.cpp:720
> +//map the rating values of WMP to Baloo rating
> +//0->0, 1->2, 25->4, 50->6,7 5->8, 99->10
> +if (rating == 0) {
`// 0->0, 1->2, 25->4, 50->6, 75->8, 99->10`
> taglibextractor.cpp:736
> +lstAS
astippich updated this revision to Diff 43885.
astippich marked 3 inline comments as done.
astippich added a comment.
- fix comment and simplify iterating
- cleanup
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16283?vs=43822&id=43885
BRANCH
ext
astippich added inline comments.
INLINE COMMENTS
> bruns wrote in taglibextractor.cpp:739
> this makes me always wonder why we don't do:
>
> // decltype(data.albumArtists) == QStringList
> for (attribute : lstAsf) {
> QString t = TStringToQString(attribute.toString());
> data.albumAr
bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.
Add the comment, otherwise its fine.
INLINE COMMENTS
> taglibextractor.cpp:843
> +} else if (mimeType == QLatin1String("audio/x-ms-wma")) {
> +TagLib::ASF::Tag* asfTags = dynamic_
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:02e8cab069ff: implement more tags for asf metadata
(authored by astippich).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16283?vs=43885&id=44366#toc
REPOSITORY
R286 KFileMetaData
CHANGES
