This revision was automatically updated to reflect the committed changes.
Closed by commit R272:3a41622348b9: prevent avahi signal racing (authored by
sitter).
REPOSITORY
R272 KDNSSD
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16298?vs=43863&id=45932
REVISION DETAIL
https://pha
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R272 KDNSSD
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16298
To: sitter, mdawson, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham added a reviewer: Frameworks.
REPOSITORY
R272 KDNSSD
REVISION DETAIL
https://phabricator.kde.org/D16298
To: sitter, mdawson, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
sitter marked 2 inline comments as done.
REPOSITORY
R272 KDNSSD
REVISION DETAIL
https://phabricator.kde.org/D16298
To: sitter, mdawson, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
sitter updated this revision to Diff 43863.
sitter added a comment.
typo-- && make isOurMsg const
REPOSITORY
R272 KDNSSD
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16298?vs=43861&id=43863
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16298
AFFECTED FILES
broulik added a comment.
Not sure if evil or genius ;)
Looks sane, as sane as it gets, obviously.
INLINE COMMENTS
> avahi_listener_p.h:29
> +
> +// Assits with listening to Avahi for all signals and then checking if the
> +// a given dbus message is meant for us or not.
*Assists
> avahi_l
sitter added inline comments.
INLINE COMMENTS
> avahi-remoteservice.cpp:104
> +
> +new org::freedesktop::Avahi::ServiceResolver(
> +s.service(),
FTR: this is obviously leaking and was doing so before as well. I'll fix it
after this diff.
REPOSITORY
R272 KDNSSD
REVISION D
sitter added reviewers: mdawson, broulik.
REPOSITORY
R272 KDNSSD
REVISION DETAIL
https://phabricator.kde.org/D16298
To: sitter, mdawson, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
https://github.com/lathiat/avahi/issues/9
Avahi has upstream signal races which can have any number of side effect
