This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a2032c52bf1b: Creating new syntax highlighting file for
Job Control Language (JCL) (authored by phily, committed by
cullmann added a comment.
Merged ;=)
Git commit a2032c52bf1b5ced774c2f58994aaeb4d233f25a by Christoph Cullmann, on
behalf of Phil Young.
Committed on 01/11/2018 at 15:54.
Pushed by cullmann into branch 'master'.
Creating new syntax highlighting file for Job Control Language
cullmann accepted this revision.
cullmann added a comment.
nice, thanks, will merge this!
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D16415
To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel,
phily updated this revision to Diff 44457.
phily added a comment.
- Added JCL test program as well as fixing recommendations (no hard coded
colors)
- Added new highlighting of steps (vs program options)
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
phily updated this revision to Diff 44454.
phily added a comment.
Adding test file for JCL and making removing hard coded colors.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16415?vs=44277=44454
REVISION DETAIL
cullmann requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D16415
To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel,
cullmann added a comment.
Hi, could one remove the two hard-coded colors and just use a different
builtin defStyleNum?
Beside that, have you some small example script that we could add as
auto-test?
e.g. something perhaps a bit larger than the snippets I can find on
phily marked an inline comment as done.
phily added a comment.
Thank you for the feedback. I've gone and updated the syntax file to explain
what JCL is and remove the `^` from the regex. Thank you for the suggestions.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
phily updated this revision to Diff 44277.
phily marked an inline comment as done.
phily added a comment.
Making changes based on reviewer comments.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16415?vs=44181=44277
REVISION DETAIL
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
Please add a small test file and explain what this highlighting language is
used for :)
INLINE COMMENTS
> jcl.xml:3
> +
> + extensions="*.JCL;*.jcl" mimetype="">
> +
phily created this revision.
phily added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
phily requested review of this revision.
REVISION SUMMARY
There is currently no support for JCL (Job
11 matches
Mail list logo
