D16416: z/OS CLIST file syntax highlighting

2018-11-01 Thread Christoph Cullmann
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R216:185b54827ab0: z/OS CLIST file syntax highlighting (authored by phily, committed by cullmann). CHANGED PRIOR TO COMMIT

D16416: z/OS CLIST file syntax highlighting

2018-10-30 Thread Christoph Cullmann
cullmann added a comment. Thanks for the needed info, will merge this. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16416 To: phily, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel,

D16416: z/OS CLIST file syntax highlighting

2018-10-29 Thread Phil Young
phily added a comment. In D16416#349335 , @cullmann wrote: > To properly push it with you as author, what is your full name + mail address? Phil Young mainframed...@gmail.com (I'm assuming you meant email address) REPOSITORY

D16416: z/OS CLIST file syntax highlighting

2018-10-27 Thread Christoph Cullmann
cullmann added a comment. To properly push it with you as author, what is your full name + mail address? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16416 To: phily, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann, dhaumann,

D16416: z/OS CLIST file syntax highlighting

2018-10-27 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. I can add the test for you, otherwise this look ok to go in. Thanks for the contribution. The Alert include is missing, but I am not sure if it is really needed ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D16416: z/OS CLIST file syntax highlighting

2018-10-26 Thread Phil Young
phily added a comment. Example CLIST can be viewed here: https://gist.githubusercontent.com/mainframed/9e9c85b7a13186e7ca51b5b47d90b575/raw/1e19fede7d203585b213d2f20700ed08baac9e07/protall.clist Looking at the code repo I wasn't sure exactly where to include the code examples.

D16416: z/OS CLIST file syntax highlighting

2018-10-26 Thread Phil Young
phily updated this revision to Diff 44278. phily marked 5 inline comments as done. phily added a comment. Fixing issues noted by reviewer REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16416?vs=44182=44278 REVISION DETAIL

D16416: z/OS CLIST file syntax highlighting

2018-10-25 Thread Dominik Haumann
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Could you explain what CLIST is used for? Please add a small test file that is also MIT licensed. INLINE COMMENTS > clist.xml:3 > + > + extensions="*.clist;*.CLIST"

D16416: z/OS CLIST file syntax highlighting

2018-10-24 Thread Phil Young
phily created this revision. phily added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. phily requested review of this revision. REVISION SUMMARY There was no support for CLIST syntax