D16464: [KSambaShare] Trim trailing / from share path

2018-10-28 Thread Stefan Brüns
bruns added a comment. In D16464#349869 , @aacid wrote: > In case you didn't see it, you broke compilation with Qt 5.9 Should be fixed: https://commits.kde.org/kio/9eb7e24aeb993f48d95b9dd4f6a3c18c33402f92 REPOSITORY R241 KIO REVISION

D16464: [KSambaShare] Trim trailing / from share path

2018-10-28 Thread Albert Astals Cid
aacid added a comment. In case you didn't see it, you broke compilation with Qt 5.9 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16464 To: bruns, #frameworks, broulik Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D16464: [KSambaShare] Trim trailing / from share path

2018-10-28 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R241:0c8506f982e0: [KSambaShare] Trim trailing / from share path (authored by bruns). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16464?vs=44320&id=44358 REVISION DETAIL

D16464: [KSambaShare] Trim trailing / from share path

2018-10-28 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH net_usershare REVISION DETAIL https://phabricator.kde.org/D16464 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16464: [KSambaShare] Trim trailing / from share path

2018-10-27 Thread Stefan Brüns
bruns edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16464 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16464: [KSambaShare] Trim trailing / from share path

2018-10-27 Thread Stefan Brüns
bruns added a dependent revision: D16466: [KSambaShare] Add unit test for "net usershare list" parser. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16464 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16464: [KSambaShare] Trim trailing / from share path

2018-10-27 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When adding usershares manually on the command line, it is common to have a pa