D16579: Fix APE tag extraction

smithjd added a comment. I realise that with all the fields referenced here having at least one standard fieldname parsed now that complaining may seem to be flogging a dead horse, but I'd like to re-iterate that identically-purposed fields should not be encouraged. This is at best a

D16579: Fix APE tag extraction

smithjd updated this revision to Diff 52185. smithjd added a comment. - Use the de-facto Album Artist field name for APE tags. Re-base. REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16579?vs=44708=52185 BRANCH master-musepackFixes (branched

D16579: Fix APE tag extraction

smithjd added a comment. In D16579#352887 , @astippich wrote: > You're doing the exact opposite of what we're asking for. > Look, I'd love to merge the bug fix for the DISC property. But we need compatibility. > I'll give you another

D16579: Fix APE tag extraction

astippich requested changes to this revision. astippich added a comment. You're doing the exact opposite of what we're asking for. Look, I'd love to merge the bug fix for the DISC property. But we need compatibility. I'll give you another reason: KFileMetaData has basically required that

D16579: Fix APE tag extraction

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Stop breaking code! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16579 To: smithjd, astippich, bruns, mgallien Cc: bruns, astippich,

D16579: Fix APE tag extraction

smithjd added a comment. In D16579#352788 , @smithjd wrote: > - Use the de-facto Album Artist field name for APE tags. > > Since the discussion around this patch has also included the Album Artist field, add the changes required for this

D16579: Fix APE tag extraction

smithjd retitled this revision from "Musepack disk number field name is DISC." to "Fix APE tag extraction". smithjd edited the summary of this revision. smithjd edited the test plan for this revision. smithjd added a reviewer: mgallien. REPOSITORY R286 KFileMetaData REVISION DETAIL