D16678: Fix root disk icon change so that it doesn't erroneously change other icons

This revision was automatically updated to reflect the committed changes. Closed by commit R245:6d0f74132fcd: Fix root disk icon change so that it doesn't erroneously change other icons (authored by ngraham). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16678?

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix-root-icon-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D16678 To: ngraham, bruns, broulik, davidedmundson Cc: kde-frameworks-devel, michaelh, ngra

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

ngraham updated this revision to Diff 44884. ngraham added a comment. Use `isStorageAccess()` rather than `isStorageVolume()` REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16678?vs=44883&id=44884 BRANCH fix-root-icon-change (branched from master) REVISIO

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

ngraham marked 2 inline comments as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16678 To: ngraham, bruns, broulik, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

ngraham updated this revision to Diff 44883. ngraham added a comment. Address review comments REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16678?vs=44882&id=44883 BRANCH fix-root-icon-change (branched from master) REVISION DETAIL https://phabricator.k

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

broulik added inline comments. INLINE COMMENTS > udisksdevice.cpp:874 > +{ > +if (queryDeviceInterface(Solid::DeviceInterface::StorageAccess)) { > +const UDisks2::StorageAccess accessIface(const_cast(this)); Can you check whether using `isStorageAccess()` is more desirable/performant

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

ngraham edited the test plan for this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16678 To: ngraham, bruns, broulik, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

ngraham created this revision. ngraham added reviewers: bruns, broulik, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY I committed D16653 too soo