This revision was automatically updated to reflect the committed changes.
Closed by commit R39:3f0c617e22ab: disconnect contextmenu from all
aboutToXXContextMenu receivers (authored by rjvbb).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16927?vs=45597=45664#toc
REPOSITORY
R39
cullmann added a comment.
You are right. Please add some comment why one disconnects all things and
push it.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D16927
To: rjvbb, #ktexteditor, #frameworks, cullmann
Cc: cullmann, kde-frameworks-devel, kwrite-devel,
rjvbb added a comment.
> Btw., the 2 nullptr in the disconnect can be left out, or?
Not to my understanding. From the docs:
Disconnect everything connected to a specific signal:
disconnect(myObject, SIGNAL(mySignal()), 0, 0);
equivalent to the non-static overloaded
cullmann added a comment.
Btw., the 2 nullptr in the disconnect can be left out, or?
+ a comment for the future would be nice in the code
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D16927
To: rjvbb, #ktexteditor, #frameworks, cullmann
Cc: cullmann,
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Sounds reasonable.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D16927
To: rjvbb, #ktexteditor, #frameworks, cullmann
Cc: cullmann, kde-frameworks-devel,
ngraham edited the summary of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D16927
To: rjvbb, #ktexteditor, #frameworks
Cc: kde-frameworks-devel, kwrite-devel, michaelh, ngraham, bruns, demsking,
head7, cullmann, kfunk, sars, dhaumann
