This revision was automatically updated to reflect the committed changes.
Closed by commit R127:d671fcd0c09d: Add option to use
wl_display_add_socket_auto (authored by fvogt).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17122?vs=50238=50241
REVISION
romangg accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17122
To: fvogt, #kwin, #plasma, romangg
Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham,
bruns
romangg added a dependent revision: D18522: Name Wayland socket automatically
when no socket name was specified.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D17122
To: fvogt, #kwin, #plasma, romangg
Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh,
fvogt updated this revision to Diff 50238.
fvogt added a comment.
Replace XDG_RUNTIME_DIR, test still passes
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17122?vs=49806=50238
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17122
fvogt marked 4 inline comments as done.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D17122
To: fvogt, #kwin, #plasma, romangg
Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham,
bruns
romangg added inline comments.
INLINE COMMENTS
> fvogt wrote in test_display.cpp:223
> That won't work reliably either though - if wayland-0 is free, but wayland-1
> is used, it would pick wayland-0 and wayland-2. Maybe it should just check
> that starting both displays at the same time
davidedmundson added inline comments.
INLINE COMMENTS
> fvogt wrote in test_display.cpp:223
> That won't work reliably either though - if wayland-0 is free, but wayland-1
> is used, it would pick wayland-0 and wayland-2. Maybe it should just check
> that starting both displays at the same time
fvogt added inline comments.
INLINE COMMENTS
> romangg wrote in test_display.cpp:223
> This fails when one tries to run the test inside another Wayland session,
> which already uses the wayland-0 socket name.
>
> What you could do here is loop until you find the first non-existing
>
romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> test_display.cpp:223
> +QVERIFY(runtimeDir.exists());
> +QVERIFY(!runtimeDir.exists("wayland-0"));
> +QVERIFY(!runtimeDir.exists("wayland-1"));
fvogt updated this revision to Diff 49806.
fvogt marked 2 inline comments as done.
fvogt added a comment.
Add some style
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17122?vs=49802=49806
BRANCH
master
REVISION DETAIL
fvogt added a comment.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D17122
To: fvogt, #kwin, #plasma
Cc: zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns
romangg added inline comments.
INLINE COMMENTS
> display.cpp:87
> +bool running = false,
> + automaticSocketNaming = false;
> QList outputs;
bool running = false;
bool automaticSocketNaming = false;
REPOSITORY
R127 KWayland
REVISION DETAIL
zzag added inline comments.
INLINE COMMENTS
> display.cpp:86-87
> QString socketName = QStringLiteral("wayland-0");
> -bool running = false;
> +bool running = false,
> + automaticSocketNaming = false;
> QList outputs;
Style:
fvogt retitled this revision from "RFC: Use wl_display_add_socket_auto by
default" to "Add option to use wl_display_add_socket_auto".
fvogt edited the summary of this revision.
fvogt edited the test plan for this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
14 matches
Mail list logo
