pranavgade updated this revision to Diff 46376.
pranavgade removed a subscriber: kde-frameworks-devel.
pranavgade added a comment.
Made a few minor changes
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17185?vs=46310=46376
REVISION DETAIL
pranavgade marked 5 inline comments as done.
pranavgade added inline comments.
INLINE COMMENTS
> jgrulich wrote in iptunnelsettingtest.cpp:79
> Use NetworkManager defines, do not define your own new defines, there is no
> reason for that.
I tried to follow the way it is done in ipv6settings.
jgrulich added inline comments.
INLINE COMMENTS
> CMakeLists.txt:31
> wirelesssecuritysettingtest
> +iptunnelsettingtest
> )
Can you please add the test in alphabetic order?
> iptunnelsettingtest.cpp:79
> +
> +map.insert(QLatin1String(NMQT_SETTING_IP_TUNNEL_CONFIG_MODE), mode);
>
pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.
REVISION SUMMARY
Added ip-tunnel settings according to
