This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:2d72fc8c496c: Add ovs-bridge and ovs-interface setting
(authored by pranavgade, committed by jgrulich).
CHANGED PRIOR
pranavgade updated this revision to Diff 46542.
pranavgade marked an inline comment as done.
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17239?vs=46537&id=46542
REVISION DETAIL
https://phabricator.kde.org/D17239
AFFECTED FILES
autotests/settin
jgrulich added inline comments.
INLINE COMMENTS
> ovsinterfacesetting.cpp:27
> +#if !NM_CHECK_VERSION(1, 10, 0)
> +#define NM_SETTING_OVS_INTERFACE_SETTING_NAME "ovs-interface"
> +#endif
I forgot that the same problem will be with NM_SETTING_OVS_INTERFACE_TYPE.
Define it too please.
REPOSITORY
pranavgade updated this revision to Diff 46537.
pranavgade marked 8 inline comments as done.
pranavgade added a comment.
Made the required changes
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17239?vs=46491&id=46537
REVISION DETAIL
https://pha
jgrulich added inline comments.
INLINE COMMENTS
> ovsbridgesetting.cpp:25
> +#include
> +
> +NetworkManager::OvsBridgeSettingPrivate::OvsBridgeSettingPrivate()
Add defines for ovs-bridge properties and name in case NM is older than NM
1.10.0.
> ovsbridgesetting.cpp:27
> +NetworkManager::OvsBr
pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.
REVISION SUMMARY
Added ovs-bridge and ovs-interface setting according to:
https://develope
