sars created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sars requested review of this revision.
REPOSITORY
R39 KTextEditor
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17241
AFFECTED FILES
src/rende
shubham added reviewers: cullmann, vkrause.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17241
To: sars, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns,
demsking, cullmann, sars, dhaumann
brauch added a comment.
Shouldn't this change simultaneously remove the line length limit ...?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17241
To: sars, cullmann, vkrause
Cc: brauch, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns,
demski
sars updated this revision to Diff 46633.
sars retitled this revision from "WIP: Disable highlighting for lines longer
than 1024 characters." to "Disable highlighting for lines longer than 1024
characters.".
sars edited the summary of this revision.
sars added a reviewer: dhaumann.
sars added a c
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
what sven said, we should also remove the code to disable highlighting
altogether when the line limit is reached, no?
INLINE COMMENTS
> katerenderer.cpp:387
>
> +if (textLi
sars added a comment.
I agree, we need to do something about the line length limit (that only wraps
the lines at the limit when opening the file).
The question is: do we totally remove the option and limit or only the option
and raise the limit.
You can still edit the document at 20
