This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2a41e4b45262: implement cover extraction for asf files
(authored by astippich).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17358?vs=46868&id=46985
REVISI
bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> embeddedimagedata.cpp:273
> }
> +QByteArray
> +EmbeddedImageData::Private::getFrontCoverFromAsf(TagLib::ASF::Tag* asfTags)
> const
Nitpick - empty line between function
astippich updated this revision to Diff 46868.
astippich added a comment.
- fix
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17358?vs=46863&id=46868
BRANCH
wma_cover
REVISION DETAIL
https://phabricator.kde.org/D17358
AFFECTED FILES
autotest
astippich added a dependency: D17357: extend list of supported mimetypes for
embedded image extractor.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D17358
To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spooru
astippich created this revision.
astippich added reviewers: bruns, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
implement support for last missing mimetype
compared to ta
