D17381: macsec setting

This revision was automatically updated to reflect the committed changes. Closed by commit R282:b5a906ba5730: macsec setting (authored by pranavgade, committed by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17381?vs=47027&id=47028#toc REPOSITORY R282 NetworkManagerQt CHA

D17381: macsec setting

jgrulich accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D17381 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

pranavgade updated this revision to Diff 47027. pranavgade marked 7 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=47021&id=47027 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settin

D17381: macsec setting

jgrulich added inline comments. INLINE COMMENTS > macsecsetting.cpp:49 > +, sendSci(true) > +, validation(NetworkManager::MacsecSetting::Disable) > +{ } Isn't default validation 2, which means "strict" in your case. > macsecsetting.cpp:294 > + > +if (mode() > 0) { > +setting

D17381: macsec setting

jgrulich added a comment. Please update full diff. REVISION DETAIL https://phabricator.kde.org/D17381 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

pranavgade updated this revision to Diff 47021. pranavgade marked 8 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=46975&id=47021 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settin

D17381: macsec setting

jgrulich added inline comments. INLINE COMMENTS > pranavgade wrote in macsecsettingtest.cpp:29 > I tried to get the version from here: > F6459587: Screenshot from 2018-12-06 22-13-34.png > > > Is that incorrect? > If so, from where do I check the version?

D17381: macsec setting

pranavgade added inline comments. INLINE COMMENTS > pranavgade wrote in macsecsetting.h:58 > From where can I get the possible values? Because I cannot find them here: > https://developer.gnome.org/NetworkManager/stable/settings-macsec.html (I mean the default values to use in the defines) REV

D17381: macsec setting

pranavgade updated this revision to Diff 46975. pranavgade marked 3 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=46958&id=46975 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settin

D17381: macsec setting

pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in macsecsettingtest.cpp:29 > This required version is not true, please verify it properly, I'm not going > to do it every time :). I tried to get the version from here: F6459587: Screenshot from 2018-12-06 22-13-34.png

D17381: macsec setting

jgrulich added inline comments. INLINE COMMENTS > macsecsettingtest.cpp:29 > + > +#if !NM_CHECK_VERSION(1, 12, 0) > +#define NM_SETTING_MACSEC_PARENT "parent" This required version is not true, please verify it properly, I'm not going to do it every time :). > macsecsetting.cpp:2

D17381: macsec setting

pranavgade updated this revision to Diff 46958. pranavgade added a comment. rebased on master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=46953&id=46958 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/s

D17381: macsec setting

jgrulich added a comment. Rebase this change on top of your previous change, this will not apply. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17381 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added macsec setting according to: https://developer.gnome.org/NetworkMan