D17406: add attributes `shared` and `__gshared`

2018-12-08 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:8741ced7fe71: add attributes `shared` and `__gshared` (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17406?vs=47037=47156

D17406: add attributes `shared` and `__gshared`

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17406#372806 , @cullmann wrote: > I can add the keywords myself then, no problem. Great, thanks. > Thought for larger contributions, I really would appreciate some real name, copyright wise I don't

D17406: add attributes `shared` and `__gshared`

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17406#372788 , @cullmann wrote: > Google tells me this are valid attributes: https://dlang.org/spec/attribute.html > > Could you extend the unit test (or add one, if none there) I don't know how to do

D17406: add attributes `shared` and `__gshared`

2018-12-07 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Google tells me this are valid attributes: https://dlang.org/spec/attribute.html Could you extend the unit test (or add one, if none there) And do you have some

D17406: add attributes `shared` and `__gshared`

2018-12-07 Thread Shubham
shubham added a reviewer: cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17406 To: aG0aep6G, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17406: add attributes `shared` and `__gshared`

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH shared-__gshared REVISION DETAIL https://phabricator.kde.org/D17406