loh.tar added a comment.
> Will wait for further advice
Still waiting if I have to undo these reference stuff. (Yes your are busy.
Just only wanted it to emphasize)
Besides, I like to add some more chars to this special handling:
_ : # @ ~ * ! $ % / \
Some of these may handy
loh.tar added a comment.
> Btw., have you perhaps played a bit with the
https://phabricator.kde.org/D12295 patch?
No, but noticed it sometime in the past
> If you use it, could you try that patch, too?
Will try it
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabrica
cullmann added a comment.
Btw., have you perhaps played a bit with the
https://phabricator.kde.org/D12295 patch?
I tried it once and it did behave ok, but I don'T use that feature that often.
If you use it, could you try that patch, too?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
htt
loh.tar added a comment.
> the change from QChar to const QChar & does not improve the amount of
copied data.
Argh! OK. Was just an impulse to do it as usual and to follow
isStartBracket(..) and isBracket(..)
Will wait for further advice
REPOSITORY
R39 KTextEditor
REVISION DETAIL
sars added inline comments.
INLINE COMMENTS
> katedocument.cpp:117
>
> -static inline QChar matchingStartBracket(QChar c, bool withQuotes)
> +static inline QChar matchingStartBracket(const QChar &c)
> {
I'm not familiar with the auto-bracket code, but the change from QChar to const
QChar & d
loh.tar added a comment.
Should you dislike the auto bracket code changes can I remove them from this
patch. They are not needed for this one and only be the byproduct of my code
studying.
As always, poor tested :-)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde
loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.
REVISION SUMMARY
The first attempt was to add these chars to the auto bracket co
