D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2019-01-07 Thread Martin Koller
This revision was automatically updated to reflect the committed changes. Closed by commit R241:a3fce6e0b7f2: avoid blocking kio_http_cache_cleaner and ensure exit with session (authored by mkoller). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17741?vs=48084&id=48924#toc REPOSITORY

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2019-01-07 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17741 To: mkoller, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2018-12-23 Thread Martin Koller
mkoller updated this revision to Diff 48084. mkoller added a comment. David is right, processEvents() seems not be needed at all - removed it. Actually while testing, I found some other bugs - mainly read/write of the scoreboard and the info from the slaves where one side wrote qint64 b

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2018-12-22 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17741 To: mkoller, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2018-12-22 Thread David Faure
dfaure added a comment. I assume the processEvents() is necessary to process DBus disconnection, then? In that case let's add a comment, so the next person doesn't think this is unnecessary (it's certainly not necessary for the QLocalServer/QLocalSocket stuff). REPOSITORY R241 KIO RE

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2018-12-22 Thread Martin Koller
mkoller edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17741 To: mkoller, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2018-12-22 Thread Martin Koller
mkoller created this revision. mkoller added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mkoller requested review of this revision. REVISION SUMMARY Currently when logging out, kio_http_cache_cleaner stays alive and blocks in QCoreA